[Piglit] [PATCH 4/7] GL_ARB_ubo/negative-bindbufferrange-range: New test for API errors.

Eric Anholt eric at anholt.net
Mon Jun 18 18:27:32 PDT 2012


---
 tests/all.tests                                    |    1 +
 .../arb_uniform_buffer_object/CMakeLists.gl.txt    |    1 +
 .../negative-bindbufferrange-range.c               |   90 ++++++++++++++++++++
 3 files changed, 92 insertions(+)
 create mode 100644 tests/spec/arb_uniform_buffer_object/negative-bindbufferrange-range.c

diff --git a/tests/all.tests b/tests/all.tests
index 3d694b4..3584281 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1705,6 +1705,7 @@ arb_uniform_buffer_object['layout-std140'] = concurrent_test('arb_uniform_buffer
 arb_uniform_buffer_object['minmax'] = concurrent_test('arb_uniform_buffer_object-minmax')
 arb_uniform_buffer_object['negative-bindbuffer-index'] = concurrent_test('arb_uniform_buffer_object-negative-bindbuffer-index')
 arb_uniform_buffer_object['negative-bindbuffer-target'] = concurrent_test('arb_uniform_buffer_object-negative-bindbuffer-target')
+arb_uniform_buffer_object['negative-bindbufferrange-range'] = concurrent_test('arb_uniform_buffer_object-negative-bindbufferrange-range')
 
 ati_draw_buffers = Group()
 spec['ATI_draw_buffers'] = ati_draw_buffers
diff --git a/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt b/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
index f29d7a8..a45189c 100644
--- a/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
+++ b/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
@@ -18,5 +18,6 @@ add_executable (arb_uniform_buffer_object-layout-std140 layout-std140.c)
 add_executable (arb_uniform_buffer_object-minmax minmax.c)
 add_executable (arb_uniform_buffer_object-negative-bindbuffer-index negative-bindbuffer-index.c)
 add_executable (arb_uniform_buffer_object-negative-bindbuffer-target negative-bindbuffer-target.c)
+add_executable (arb_uniform_buffer_object-negative-bindbufferrange-range negative-bindbufferrange-range.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_uniform_buffer_object/negative-bindbufferrange-range.c b/tests/spec/arb_uniform_buffer_object/negative-bindbufferrange-range.c
new file mode 100644
index 0000000..d3e29f6
--- /dev/null
+++ b/tests/spec/arb_uniform_buffer_object/negative-bindbufferrange-range.c
@@ -0,0 +1,90 @@
+/*
+ * Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/** @file negative-bindbufferrange-range.c
+ *
+ * From the GL_ARB_uniform_buffer_object spec:
+ *
+ *     "For BindBufferRange, <offset> specifies a starting offset into
+ *      the buffer object <buffer>, and <size> specifies the amount of
+ *      data that can be read from the buffer object while used as the
+ *      storage for a uniform block. Both <offset> and <size> are in
+ *      basic machine units. The error INVALID_VALUE is generated if
+ *      the value of <size> is less than or equal to zero, if <offset>
+ *      + <size> is greater than the value of BUFFER_SIZE, or if
+ *      <offset> is not a multiple of the implementation-dependent
+ *      required alignment
+ *      (UNIFORM_BUFFER_OFFSET_ALIGNMENT). BindBufferBase is
+ *      equivalent to calling BindBufferRange with <offset> zero and
+ *      <size> equal to the size of <buffer>."
+ */
+
+#include "piglit-util.h"
+
+int piglit_width = 100;
+int piglit_height = 100;
+int piglit_window_mode = GLUT_DOUBLE | GLUT_RGB | GLUT_ALPHA;
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	GLint alignment;
+	GLuint bo;
+	int size = 1024;
+	int index = 0;
+	int i;
+
+	piglit_require_extension("GL_ARB_uniform_buffer_object");
+
+	glGenBuffers(1, &bo);
+	glBindBuffer(GL_UNIFORM_BUFFER, bo);
+	glBufferData(GL_UNIFORM_BUFFER, size, NULL, GL_STATIC_READ);
+
+	glBindBufferRange(GL_UNIFORM_BUFFER, index, bo, 0, -1);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		pass = false;
+
+	glBindBufferRange(GL_UNIFORM_BUFFER, index, bo, 0, size + 1);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		pass = false;
+
+	glBindBufferRange(GL_UNIFORM_BUFFER, index, bo, 1, size);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		pass = false;
+
+	glGetIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT, &alignment);
+	for (i = 1; i < alignment; i++) {
+		glBindBufferRange(GL_UNIFORM_BUFFER, index, bo, i, 4);
+		if (!piglit_check_gl_error(GL_INVALID_VALUE))
+			pass = false;
+	}
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
+
+enum piglit_result piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
-- 
1.7.10



More information about the Piglit mailing list