[Piglit] [PATCH 4/4] Add test to verify sample alpha to one with multisample fbo

[Anuj Phogat]

On Sat, Jun 16, 2012 at 8:09 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 8 June 2012 14:46, <anuj.phogat at gmail.com> wrote:
>>
>> From: Anuj Phogat <anuj.phogat at gmail.com>
>>
>> This test varifies that with GL_SAMPLE_ALPHA_TO_ONE enabled, each sample's
>> alpha value is replaced by maximum alpha value i.e. 1.0.
>
>
> This test is:
>
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
>
> I would recommend adding two additional tests, preferably in separate files:
>
> 1. We should make sure that when both GL_SAMPLE_ALPHA_TO_ONE and
> GL_SAMPLE_ALPHA_TO_COVERAGE are enabled, GL_SAMPLE_ALPHA_TO_COVERAGE takes
> effect first (that is, the coverage value needs to be computed from the
> alpha value *before* the alpha value gets changed to 1).
>
To avoid lot of code duplication, I included this as a sub test in
sample-alpha-to-coverage test case:
[PATCH 3/4] Add test to verify sample alpha to coverage with multisample fbo.

Do you want me to split it into a separate test case?

> 2. We should make sure that if GL_SAMPLE_ALPHA_TO_ONE is enabled and
> GL_MULTISAMPLE is disabled, alpha values are not modified.  Also, we should
> make sure that if GL_SAMPLE_ALPHA_TO_ONE is enabled and the buffer is
> single-sampled, alpha values are not modified.
>
I will work on this test case.

Thanks
Anuj