[Piglit] [PATCH] Make piglitutil library API-independent

Tom Stellard thomas.stellard at amd.com
Fri Jun 22 09:50:26 PDT 2012


On Fri, Jun 22, 2012 at 02:25:57AM +0200, Blaž Tomažič wrote:
> Currently all utility libraries (piglitutil, piglitutil_gles1,
> piglitutil_gles2) have built-in the same API-independent code and the
> code from piglit-util.{c,h} contains OpenGL functionality. To share more
> code across different APIs (e.g. OpenCL, OpenGL) this code should be
> split. piglit-util.{c,h} and piglitutil library should be
> API-independent.
> 
> 
>       * Commits 1 and 2:
>         OpenGL-dependent code from piglit-util.{c,h} is moved to
>         piglit-util-gl-common.{c,h} (All includes from other files are
>         properly renamed).
>         File piglit-util-enum.c is renamed to piglit-util-gl-enum.c for
>         the same purpose, because it contains enums from OpenGL.
>         
>       * Commit 3:
>         The function for reading files from shader-load.c is moved to
>         piglit-util.c, because it doesn't depend on any API or shaders
>         (as its name wrongly suggests). In the process shader-load.c is
>         deleted because it contains no other code.
>         
>       * Commits 4 and 5:
>         The piglitutil library is split to utility library for OpenGL
>         (piglitutil_gl) and API-independent utility library
>         (piglitutil). All other utility libraries are now linked to
>         piglitutil and all OpenGL test executables to piglitutil_gl.
> 
> 
> The commits for this patch are on this repo [1] on branch
> piglitutil-split (master..piglitutil-split or 14366de..b38b62c).
>

Hi Blaž,

Thanks for splitting this up.  It looks OK to me, but someone a little
more familiar with the piglit code should probably look at it too.

-Tom
> 
> Blaž
> 
> [1] git://github.com/blazt/piglit.git
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit



More information about the Piglit mailing list