[Piglit] [PATCH] glsl-1.30: Verify proper conversion of large floats to uints.

Chad Versace chad.versace at linux.intel.com
Fri Jun 22 13:46:41 PDT 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/13/2012 04:59 PM, Paul Berry wrote:
> This patch adds two new tests that exercise a bug in Mesa/i965: conversion from float to uint was being done in a
> two step process: convert first to int and then to uint.  Since i965 uses saturating arithmetic in float->int
> conversion, this caused conversion to give the wrong result for values greater than 0x7fffffff.
> 
> I'll be submitting a Mesa fix shortly. --- .../execution/fs-float-uint-conversion.shader_test |   37
> +++++++++++++++++++ .../execution/vs-float-uint-conversion.shader_test |   38 ++++++++++++++++++++ 2 files changed,
> 75 insertions(+), 0 deletions(-) create mode 100644
> tests/spec/glsl-1.30/execution/fs-float-uint-conversion.shader_test create mode 100644
> tests/spec/glsl-1.30/execution/vs-float-uint-conversion.shader_test


Looks good.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP5NmvAAoJEAIvNt057x8i7WEP/iFvXnOTZ4Mezd0JHIobucG3
zSNi+i2TmD/DskIrtNzggWyxTxIBr6n5HqavT8Tv960koqJFxD0gAc+yNlIZ2LGO
xX1F2UAsH9vti2ZJO2xKo/X6D+4ltDWRgpvtnr3Gffteb+dfglIGqzgl83qty5jy
9dB9ldgF0Tg6ljtysyTZCZmZLg0FimCiym+r9tt17Msc/twH6jsVRvA7SIM1RE+t
D/hyAyu2iXS1FwoDz2Ovourj/B3wRx5zGURU42zjemzfEd0Ch9VacSX/U9wY9aE4
A6HlJiyjom1ieTyb53rXBVp2UwH7GR7tNtwoQvlBnN8AUlFnQYPR1rdtAc9KrKl7
k2LwPIbS64LUJFT9XOQTKhqz2arzQqdTcwo07I3ieyQDrFkSPawm0Ul9GFcsQlzt
51lg43NS/25WDOhpbTB81hPTZb6lUqybz5omFzRhP4cx7CiIACXkfibK91ioa9mY
jJuwFAwzCDraOu/SRzXq5iHZD0YW3qyjsRKyNtUwY1jqiCrnkF5TfIpCts1zQC9I
q+R4POD8+gg0JPYSaiWBsPELOwF3m747BcgGxsOBxGOaP799MYcjnReG2+HODhCS
kKLBbVEQvP33fAlB/F7LDxQ23mtbFdQ47IcaMT8vn5v23C4+hN0vcNGPfGs16FXu
9n0uYz54v7IiYDpZJQyd
=t80C
-----END PGP SIGNATURE-----


More information about the Piglit mailing list