[Piglit] [PATCH] ext_framebuffer_multisample: fix turn-on-off test

[Paul Berry]

On 21 June 2012 13:39, Anuj Phogat <anuj.phogat at gmail.com> wrote:

> Set combine_depth_stencil flag to true while creating multisample FBO.
> This is to avoid "Framebuffer not complete" error message with drivers
> which don't allow creating separate depth and stencil attachments to
> a FBO. e.g. NVIDIA's proprietary drivers.
>

Good catch.

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  .../ext_framebuffer_multisample/turn-on-off.cpp    |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/tests/spec/ext_framebuffer_multisample/turn-on-off.cpp
> b/tests/spec/ext_framebuffer_multisample/turn-on-off.cpp
> index 0e644da..6c15092 100644
> --- a/tests/spec/ext_framebuffer_multisample/turn-on-off.cpp
> +++ b/tests/spec/ext_framebuffer_multisample/turn-on-off.cpp
> @@ -130,7 +130,6 @@ piglit_init(int argc, char **argv)
>        }
>
>        piglit_require_gl_version(30);
> -       piglit_require_GLSL_version(130);
>
>        /* Skip the test if num_samples > GL_MAX_SAMPLES */
>        glGetIntegerv(GL_MAX_SAMPLES, &max_samples);
> @@ -141,7 +140,7 @@ piglit_init(int argc, char **argv)
>
>        test = create_test(TEST_TYPE_COLOR, num_samples,
>                           false /*small*/,
> -                          false /* combine_depth_stencil */,
> +                          true /* combine_depth_stencil */,
>                           pattern_width, pattern_height,
>                           16 /* supersample_factor */);
>  }
> --
> 1.7.7.6
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120622/865d8190/attachment.html>