[Piglit] [PATCH] Make piglitutil library API-independent

[Blaž Tomažič]

On pet, 2012-06-22 at 15:12 -0700, Chad Versace wrote:
> Blaz,
> 
> Thanks for splitting the earlier patch into this series of 5. As a result, the changes were much easier to review.
> Everything looks good to me and is
>   Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> When you feel that the review process is complete and are ready to commit this, submit a pull request.

Thank you for reviewing.

I have received an email from Eric Anholt about the patches (don't know
why he didn't cc the mailing list, he probably forgot) and he raises a
question why do the new files have '-common' in their names
(piglit-util-gl-common.[ch]).
I named them this way because they have code common to gl and gles. But
while we can't have code from piglit-util-gl-common.c in
piglit-util-gl.c (because then the contents should be copied to
piglit-util-gles.c too), we can have the gl/gles utilities header in
piglit-util-gl.h instead of piglit-util-gl-common.h. So which name
should we use for the header?

Before submitting a pull request should I rebase my commits for patch on
master HEAD to check that there aren't any new includes that involve the
old headers?

> Since Piglit will soon have OpenCL tests, it is probably a good idea for us to begin renaming the GL-specific utility
> symbols so that they are prefixed with `piglit_gl`. However, there is no rush there.

I agree, I am already using 'piglit_cl' prefix for OpenCL-specific
symbols.

Blaž