[Piglit] [PATCH 1/3] security/initialized-texmemory - test contents of unitialized texture memory

Brian Paul brianp at vmware.com
Wed Jun 27 15:31:07 PDT 2012


This is the first of a new category of piglit tests that exercise
things related to security.

The first test, initialized-texmemory, creates a texture image with
unspecified contents (pixels=NULL).  We draw a polygon with the texture
and see what we get.  Ideally, we'd get a constant/black image and not
some random VRAM data from another application or another user (like a
window image).  The OpenGL spec doesn't say that texture memory should
be initialized in this situation so if the test fails we return "WARN"
rather than "FAIL".
---
 tests/CMakeLists.txt                   |    1 +
 tests/all.tests                        |    5 ++
 tests/security/CMakeLists.gl.txt       |   16 ++++++
 tests/security/CMakeLists.txt          |    1 +
 tests/security/initialized-texmemory.c |   87 ++++++++++++++++++++++++++++++++
 5 files changed, 110 insertions(+), 0 deletions(-)
 create mode 100644 tests/security/CMakeLists.gl.txt
 create mode 100644 tests/security/CMakeLists.txt
 create mode 100644 tests/security/initialized-texmemory.c

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 1a53693..05824b4 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -12,6 +12,7 @@ add_subdirectory (glx)
 add_subdirectory (glslparsertest)
 add_subdirectory (hiz)
 add_subdirectory (asmparsertest)
+add_subdirectory (security)
 add_subdirectory (shaders)
 add_subdirectory (texturing)
 add_subdirectory (spec)
diff --git a/tests/all.tests b/tests/all.tests
index 63937b9..eabf8ac 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -369,6 +369,10 @@ add_plain_test(general, 'windowoverlap')
 add_plain_test(general, 'clear-accum')
 add_fbo_depthstencil_tests(general, 'default_fb')
 
+security = Group()
+add_plain_test(security, 'initialized-texmemory')
+
+
 shaders = Group()
 
 def add_shader_test_dir(group, dirpath, recursive=False):
@@ -2368,6 +2372,7 @@ profile.tests['glslparsertest'] = glslparsertest
 profile.tests['asmparsertest'] = asmparsertest
 profile.tests['mesa'] = mesa
 profile.tests['shaders'] = shaders
+profile.tests['security'] = security
 profile.tests['texturing'] = texturing
 profile.tests['spec'] = spec
 profile.tests['glx'] = glx
diff --git a/tests/security/CMakeLists.gl.txt b/tests/security/CMakeLists.gl.txt
new file mode 100644
index 0000000..bddd591
--- /dev/null
+++ b/tests/security/CMakeLists.gl.txt
@@ -0,0 +1,16 @@
+
+include_directories(
+	${GLEXT_INCLUDE_DIR}
+	${OPENGL_INCLUDE_PATH}
+)
+
+link_libraries (
+	piglitutil
+	${OPENGL_gl_LIBRARY}
+	${OPENGL_glu_LIBRARY}
+)
+
+
+piglit_add_executable (initialized-texmemory initialized-texmemory.c)
+
+# vim: ft=cmake:
diff --git a/tests/security/CMakeLists.txt b/tests/security/CMakeLists.txt
new file mode 100644
index 0000000..144a306
--- /dev/null
+++ b/tests/security/CMakeLists.txt
@@ -0,0 +1 @@
+piglit_include_target_api()
diff --git a/tests/security/initialized-texmemory.c b/tests/security/initialized-texmemory.c
new file mode 100644
index 0000000..ecca53e
--- /dev/null
+++ b/tests/security/initialized-texmemory.c
@@ -0,0 +1,87 @@
+/*
+ * Copyright © 2012 VMware, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Test that texture memory is initialized to a constant color and not
+ * stale data that may show old contents of VRAM.
+ *
+ * To pass this test an OpenGL implementation should initialize the
+ * contents of the new buffer to some fixed value (like all zeros).
+ * But since that's not spec'd by OpenGL, we only return WARN instead of
+ * FAIL if that's not the case.
+ *
+ * Brian Paul
+ * June 2012
+ */
+
+#include "piglit-util.h"
+
+PIGLIT_GL_TEST_MAIN(
+    512 /*window_width*/,
+    512 /*window_height*/,
+    GLUT_RGB | GLUT_DOUBLE)
+
+
+enum piglit_result
+piglit_display(void)
+{
+	GLfloat firstPixel[4];
+	bool pass = true;
+
+        /* init color buffer to red */
+	glClearColor(1, 0, 0, 1);
+	glClear(GL_COLOR_BUFFER_BIT);
+
+	glEnable(GL_TEXTURE_2D);
+
+        piglit_draw_rect_tex(0, 0, piglit_width, piglit_height,
+                             0.0, 0.0, 1.0, 1.0);
+
+	/* The whole image should be same color */
+	glReadPixels(0, 0, 1, 1, GL_RGBA, GL_FLOAT, firstPixel);
+	pass = piglit_probe_rect_rgb(0, 0, piglit_width, piglit_height,
+				     firstPixel);
+
+	piglit_present_results();
+
+	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
+
+
+void
+piglit_init(int argc, char **argv)
+{
+        GLsizei width = 1024, height = 1024;
+	GLuint tex;
+
+        /* Create texture image with pixels=NULL (undefined) */
+	glGenTextures(1, &tex);
+	glBindTexture(GL_TEXTURE_2D, tex);
+        glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0,
+                     GL_RGBA, GL_UNSIGNED_BYTE, NULL);
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+        glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE);
+
+	piglit_ortho_projection(piglit_width, piglit_height, GL_FALSE);
+}
-- 
1.7.3.4



More information about the Piglit mailing list