[Piglit] [PATCH 02/15] Stop using GLEW extension macros

Paul Berry stereotype441 at gmail.com
Sat Mar 3 08:18:11 PST 2012


On 2 March 2012 18:39, Eric Anholt <eric at anholt.net> wrote:

> On Fri,  2 Mar 2012 15:40:20 -0800, Paul Berry <stereotype441 at gmail.com>
> wrote:
> > Several tests were checking for the presence of GL extensions using
> > GLEW macros.  This patch changes the tests to use
> > piglit_is_extension_supported(), which provides the same functionality
> > in a way that is not dependent on GLEW.
>
> > diff --git a/tests/fbo/fbo-clear-formats.c
> b/tests/fbo/fbo-clear-formats.c
> > index df0d854..ab41c45 100644
> > --- a/tests/fbo/fbo-clear-formats.c
> > +++ b/tests/fbo/fbo-clear-formats.c
> > @@ -271,7 +271,7 @@ test_mipmap_drawing(int x, int y, int dim, int
> level, GLuint internalformat)
> >       if (compressed && dim < 8)
> >               return GL_TRUE;
> >
> > -     if (GLEW_ARB_depth_texture) {
> > +     if (piglit_is_extension_supported("ARB_depth_texture")) {
> >               glGetTexLevelParameteriv(GL_TEXTURE_2D, level,
> >                                        GL_TEXTURE_DEPTH_SIZE, &d_size);
>
> The other callers of piglit_is_extension_supported() ask for
> GL_ARB_whatever instead of ARB_whatever.  Seems like we should stick
> with that.
>

Oh yeah.  You're right.  I'll fix that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120303/ac91a9af/attachment.html>


More information about the Piglit mailing list