[Piglit] [PATCH 1/2] glslparsertest: Allow ! in extension list to require non-support.

Eric Anholt eric at anholt.net
Mon Mar 12 12:39:57 PDT 2012


On Mon, 12 Mar 2012 00:10:16 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> For example:
> // [config]
> // required_extensions: !GL_ARB_draw_instanced
> // [end config]
> will cause the test to run only if the GL_ARB_draw_instanced is _not_
> advertised.

Seems like a reasonable feature.

Reviewed-by: Eric Anholt <eric at anholt.net>

For the feature macro testing, I'm thinking we should probably have a C
test that encodes what we understand about how the feature macros work
and how to test them using command-line args, instead of writing tests
per-extension (or, in the current case, just for the one extension we
bothered with).

I haven't reviewed the second patch, because while it looks sane to me,
I seem to recall that idr's interpretation was that the macros didn't
exist unless you #extensioned.  But I may be totally wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120312/eb71e84b/attachment.pgp>


More information about the Piglit mailing list