[Piglit] [PATCH v2 08/13] piglit-dispatch: Add generated files.

Jose Fonseca jfonseca at vmware.com
Mon Mar 12 15:08:25 PDT 2012

----- Original Message -----
> This patch adds the files glapi/glapi.json,
> tests/util/generated_dispatch.c, and tests/util/generated_dispatch.h,
> which were generated using the command "make piglit_dispatch_gen".
> ---
>  glapi/glapi.json                |55751
>  +++++++++++++++++++++++++++++++++++++++
>  tests/util/generated_dispatch.c |39920 ++++++++++++++++++++++++++++
>  tests/util/generated_dispatch.h |14993 +++++++++++

Do any of these files really need to be commited, given the source .spec have been committed too?

If so, have you ensured that everytime they are regenerate they  (Care must be taken with python dictionaries as they easily lead to variable ordering).

But I feel that either the derived result is committed (and the source is left out and manually downloaded when upstream changes) or the sources (and the derived files generated during the build). Including both seems redundant.


More information about the Piglit mailing list