[Piglit] [PATCH v2 10/13] piglit-dispatch: Switch to using piglit-dispatch instead of GLEW.
Jose Fonseca
jfonseca at vmware.com
Fri Mar 16 12:04:01 PDT 2012
----- Original Message -----
> On 03/12/2012 02:41 PM, Paul Berry wrote:
> > Previous patches set up the piglit-dispatch infrastructure but did
> > not
> > use it. This patch enables piglit-dispatch and uses it instead of
> > GLEW.
> >
> > No piglit regressions on Intel SandyBridge (Linux) or Mac OSX.
>
> Nice. Only one more platform to conquer.
>
> > #if defined(USE_OPENGL)
> > -# include "glew.h"
> > - /* Include the real headers too, in case GLEW misses something.
> > */
> > +# include "piglit-dispatch.h"
> > + /* Include the real headers too, in case piglit-dispatch misses
> > something. */
> > # ifdef __APPLE__
> > # include <OpenGL/gl.h>
> > # include <OpenGL/glu.h>
>
> Shouldn't Apple's <OpenGL/gl.h> be removed too?
> I think we discussed this before, but I don't remember the
> conclusion.
It's probably pointless if all GL defitions are done before.
But note that Apple's glext.h is non standard:
https://github.com/apitrace/apitrace/blob/master/thirdparty/khronos/GL/glext.patch
It's probably better to replicate this on piglit-dispatch too.
Jose
More information about the Piglit
mailing list