[Piglit] [PATCH v2 10/13] piglit-dispatch: Switch to using piglit-dispatch instead of GLEW.
stereotype441 at gmail.com
Tue Mar 20 12:52:25 PDT 2012
On 20 March 2012 07:11, Jose Fonseca <jfonseca at vmware.com> wrote:
> IMO the biggest CON is that, because specs and implementations vary in
> subtle ways, aliases cannot be trusted to be truly interchangeable. So a
> mechanism that fully abstracts aliases is a) introducing a hidden
> variability factor, b) makes it easy to forget to check the differences.
> That said, I agree with you, we don't need to throw the baby with the
> water, and we can still have a code generation for handling aliases while
> still maintain close control over which extension is used, as some of your
> ideas achieve.
> I'm happy to let you decide what you think it's best here.
Ok, thanks. I will plan to keep the code as is for the initial commit, and
I will try some of the ideas we've talked about as follow-up patches.
> > Incidentally, some of us at Intel have been tossing around the idea
> > of doing away with all.tests altogether, and instead annotating the
> > individual .c files with specially-formatted comments indicating how
> > each test should be run (much as we already do for GLSL parser
> > tests). If we did that, then it seems like it would be fairly easy
> > for every test to specify which combinations of GL versions and
> > extensions it supports, and the piglit framework could automatically
> > invoke it multiple times if necessary to test each set of aliased
> > functions. If we went with this approach, it would have the
> > additional advantage that the piglit framework could take
> > responsibility for skipping tests that don't apply to the current
> > implementation, rather than being forced to each of those tests
> > individually and collect their "skip" results.
> Sounds a very nice idea.
Thanks for the feedback. I'll try to keep the conversation going about
this in the next several weeks.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Piglit