[Piglit] [PATCH] arb blend func extended - check errors at glBegin

[Dave Airlie]

From: Dave Airlie <airlied at redhat.com>

The spec says we should error after Begin if the blend factors are applied
to an illegal draw buffer.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 .../arb_blend_func_extended/api/CMakeLists.gl.txt  |    1 +
 .../arb_blend_func_extended/api/error-at-begin.c   |  118 ++++++++++++++++++++
 2 files changed, 119 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/arb_blend_func_extended/api/error-at-begin.c

diff --git a/tests/spec/arb_blend_func_extended/api/CMakeLists.gl.txt b/tests/spec/arb_blend_func_extended/api/CMakeLists.gl.txt
index 5ee67ba..27e9204 100644
--- a/tests/spec/arb_blend_func_extended/api/CMakeLists.gl.txt
+++ b/tests/spec/arb_blend_func_extended/api/CMakeLists.gl.txt
@@ -14,4 +14,5 @@ link_libraries (
 piglit_add_executable (arb_blend_func_extended-bindfragdataindexed-invalid-parameters bindfragdataindexed-invalid-parameters.c)
 piglit_add_executable (arb_blend_func_extended-getfragdataindex getfragdataindex.c)
 piglit_add_executable (arb_blend_func_extended-blend-api blend-api)
+piglit_add_executable (arb_blend_func_extended-error-at-begin error-at-begin)
 # vim: ft=cmake:
diff --git a/tests/spec/arb_blend_func_extended/api/error-at-begin.c b/tests/spec/arb_blend_func_extended/api/error-at-begin.c
new file mode 100644
index 0000000..bc345c8
--- /dev/null
+++ b/tests/spec/arb_blend_func_extended/api/error-at-begin.c
@@ -0,0 +1,118 @@
+/*
+ * Copyright © 2011 Red Hat
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file error-at-begin.c
+ *
+ * \author Dave Airlie
+ * ARB_blend_func_extended states in ERRORS section
+ * The error INVALID_OPERATION is generated by Begin or any procedure that
+ * implicitly calls Begin if any draw buffer has a blend function requiring the
+ * second color input (SRC1_COLOR, ONE_MINUS_SRC1_COLOR, SRC1_ALPHA or
+ * ONE_MINUS_SRC1_ALPHA), and a framebuffer is bound that has more than
+ * the value of MAX_DUAL_SOURCE_DRAW_BUFFERS-1 active color attachements.
+ */
+#include "piglit-util.h"
+
+int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE;
+int piglit_width = 100, piglit_height = 100;
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+static GLuint fbo;
+static GLuint max_buffers;
+
+static void
+create_fbo(void)
+{
+   GLuint rb[32];
+   int i;
+
+   glGenFramebuffersEXT(1, &fbo);
+   glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, fbo);
+
+   glGenRenderbuffersEXT(max_buffers, rb);
+
+   for (i = 0; i < max_buffers; i++) {
+      glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, rb[i]);
+
+      glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT,
+                                   GL_COLOR_ATTACHMENT0 + i,
+                                   GL_RENDERBUFFER_EXT,
+                                   rb[i]);
+      glRenderbufferStorageEXT(GL_RENDERBUFFER_EXT, GL_RGBA,
+                               piglit_width, piglit_height);
+   }
+}
+
+void piglit_init(int argc, char **argv)
+{
+	GLint max_dual_source;
+	GLenum buffers[32];
+	int i;
+	piglit_require_gl_version(30);
+	piglit_require_extension("GL_ARB_blend_func_extended");
+
+	/* This test needs some number of draw buffers, so make sure the
+	 * implementation isn't broken.  This enables the test to generate a
+	 * useful failure message.
+	 */
+	glGetIntegerv(GL_MAX_DUAL_SOURCE_DRAW_BUFFERS, &max_dual_source);
+	if (max_dual_source < 1) {
+		fprintf(stderr,
+			"ARB_blend_func_extended requires GL_MAX_DUAL_SOURCE_DRAW_BUFFERS >= 1.  "
+			"Only got %d!\n",
+			max_dual_source);
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	max_buffers = max_dual_source + 1;
+
+	create_fbo();
+
+	for (i = 0; i < max_buffers; i++)
+		buffers[i] = GL_COLOR_ATTACHMENT0_EXT + i;	
+
+	glDrawBuffersARB(max_buffers, buffers);
+	
+	for (i = 0; i < max_buffers; i++) {
+		if (i >= max_dual_source)
+			glBlendFunciARB(i, GL_SRC1_ALPHA, GL_ONE_MINUS_SRC1_ALPHA);
+		else
+			glBlendFunciARB(i, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
+		glEnableIndexedEXT(GL_BLEND, i);
+	}
+
+	glEnable(GL_BLEND);
+
+        glBegin(GL_QUADS);
+
+	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+		piglit_report_result(PIGLIT_FAIL);
+	else
+		piglit_report_result(PIGLIT_PASS); 	  
+}
-- 
1.7.7.6