[Piglit] [PATCH 1/3] enable -fbo for another batch of things
brianp at vmware.com
Tue May 1 07:33:32 PDT 2012
This looks good. It looks like there's a few more glFlush()/Finish()
calls that can be removed in a follow-on.
One more comment below.
> diff --git a/tests/texturing/texredefine.c b/tests/texturing/texredefine.c
> index 2f0676c..7e00ecb 100644
> --- a/tests/texturing/texredefine.c
> +++ b/tests/texturing/texredefine.c
> @@ -194,7 +194,7 @@ piglit_display(void)
> - glutSwapBuffers();
> + piglit_present_results();
> return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> @@ -209,7 +209,7 @@ static void Reshape(int width, int height)
> void piglit_init(int argc, char **argv)
> - glutReshapeFunc(Reshape);
> + /*glutReshapeFunc(Reshape);*/
I guess you're commenting out that line because concurrent tests can't
use glutReshapeFunc()? I haven't looked into that.
Anyway, I think the right fix is to move the body of Reshape() into
the piglit_display() function and then remove Reshape(). As-is the
test will fail if the window size changes.
While we seldom resize piglit windows, piglit tests usually shouldn't
fail if the window does get resized (and it's not unheard of for
window managers to resize windows). In the past I've found some bugs
by resizing test windows.
More information about the Piglit