[Piglit] [PATCH v2] Test rendering to various miplevels of depth and stencil textures.

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/02/2012 02:30 PM, Paul Berry wrote:
> This patch adds a new test, "depthstencil-render-miplevels", which
> verifies that we can render to all miplevels of depth and stencil
> textures.  It exposes two bugs in Mesa's current i965 driver:
> 
> - Miptree offsets aren't being calculated correctly for HiZ and
>   separate stencil buffers, causing miplevels to overlap in those
>   buffers.
> 
> - When binding the same texture to the GL_DEPTH_ATTACHMENT and
>   GL_STENCIL_ATTACHMENT points, Mesa is trying to share internal data
>   structures even if the miplevels don't match; as a result,
>   transitioning from one miplevel to another doesn't work.
> 
> The test is capable of running at any texture size (including
> non-power-of-two texture sizes).  However, because of some GPU hang
> bugs in Mesa's current i965 driver, I've limited it to test at a
> texture size of 1024x1024 for now.
> 
> v2: Added comment "/* Anonymous namespace */" on the final closing
> brace.  Adjusted the naming scheme for the subtests to allow
> additional format combinations to be added in the future.  Also added
> format combinations involving z32f and z32f_s8.

Thanks for adding tests for the extra formats.

> ---
>  tests/all.tests                                   |   19 +
>  tests/texturing/CMakeLists.gl.txt                 |    1 +
>  tests/texturing/depthstencil-render-miplevels.cpp |  404 +++++++++++++++++++++
>  3 files changed, 424 insertions(+), 0 deletions(-)
>  create mode 100644 tests/texturing/depthstencil-render-miplevels.cpp


[snip]

> + * Usage: depthstencil-render-miplevels <texture_size> <buffer_combination>
> + *
> + *  buffer_combination:          buffer attachments:
> + *  stencil                      stencil->DEPTH_STENCIL
> + *  depth_x                      depth->DEPTH_STENCIL
> + *  depth                        depth->DEPTH_COMPONENT
> + *  d16                          depth->DEPTH_COMPONENT16
> + *  depth_x_and_stencil          depth->DEPTH_STENCIL, stencil->DEPTH_STENCIL
> + *  stencil_and_depth_x          (as above, but stencil attached first)
> + *  depth_and_stencil            depth->DEPTH_COMPONENT, stencil->DEPTH_STENCIL
> + *  stencil_and_depth            (as above, but stencil attached first)
> + *  depth_stencil_shared         depth->DEPTH_STENCIL<-stencil
> + *  stencil_depth_shared         (as above, but stencil attached first)
> + *  depth_stencil_single_binding depth_stencil->DEPTH_STENCIL

This comment needs to be updated. Other than that,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPow3ZAAoJEAIvNt057x8iPIIP/0VrW5t/IXC9XdJpUcv2Gxo8
93meiVtpacRyf6ozCzHQd8NeLnrSE0ZPfQqTIvHi/wmcOmRgngiq6fbjqOFdZ3X9
OziyQhi2qoMqGSUu5z0jyoZdbua2ceojz7DPuBu5539Kq7/fMJXvzWzcYA2M81N2
2j1yhBmh6N1lNOL5gYHKXwxfptYef434ipXozBplGzduDQwaN1YUL8yKPR/x7yUf
KQpJIpFfAdfx/S2df3YuQUHpUj5rvrUHuQgOK3ZQ+rbDjyDGA2d4RP4cpKpNBjzt
u5gEFTe64W1Hgg02olwRlnSKn4dwAckJf8Y0qbLWwxRJkl2JSD/PlPlIFO858ypx
570+p51BluXuA3iMZQr4lbQxiHFv7jsotj/UnKthTRXZpxN7L4kD/V2HvXS6FGJV
yH5VjM96oUhFz05FffzjTDW7TF+s6+wML3/B8XPVkUN7V9IvMQDHocFJYXyLl7z2
q1pPE/ZZBAJeXZxKqxj+2WC2U4lp/psiqLad9JvJpgaqyShhkhdTrznZOAjfptNd
ikoVwHxeGStMw5HuIEfScEVhMswD48IBFDWfdW2CoAcNg0xvYDyZJgovtTa3hh0q
mE97DmnMSggRcaIGIr1CyLOotgD93kIgNe7QL53O9FCTIbTRpez00JtRq1H3+pGG
frUb1xRaxM8W/CIGnJUA
=CyQm
-----END PGP SIGNATURE-----