[Piglit] [PATCH 1/2] framework: Don't create Glean result dir if it's a variable.

Kenneth Graunke kenneth at whitecape.org
Wed May 9 00:05:30 PDT 2012

I want to be able to get a list of commands being run without specifying
an actual result directory.  So, I'm specifying it as $GLEAN_RESULT_DIR.

In that case, I don't want it to create a literal directory called
$GLEAN_RESULT_DIR.  (The % is for python-style substitutions.)

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
 framework/gleantest.py |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Ultimately, I'd rather get glean to quit outputting all this stuff during
automated runs.  It's useless...especially since each invocation of (for
example) glean's glsl1 overwrites results/glean/glsl1/glsl1/results.

Might take a stab at that in a future patch.

diff --git a/framework/gleantest.py b/framework/gleantest.py
index c746e66..bf9a164 100644
--- a/framework/gleantest.py
+++ b/framework/gleantest.py
@@ -45,7 +45,8 @@ class GleanTest(ExecTest):
 			"-v", "-v", "-v",
 			"-t", "+"+name])
-		checkDir(os.path.join(gleanResultDir(resdir), name), False)
+		if resdir[0] not in '$%':
+			checkDir(os.path.join(gleanResultDir(resdir), name), False)
 		self.name = name

More information about the Piglit mailing list