[Piglit] [PATCH] primitive-restart: test primitive-restart with VBO

[Olivier Galibert]

On Fri, May 11, 2012 at 09:06:21AM -0600, Brian Paul wrote:
> On 05/10/2012 11:34 AM, Jordan Justen wrote:
> > On Thu, May 10, 2012 at 9:26 AM, Jordan Justen<jljusten at gmail.com>  wrote:
> >> On Thu, May 10, 2012 at 8:58 AM, Jordan Justen<jljusten at gmail.com>  wrote:
> >>> On Thu, May 10, 2012 at 7:10 AM, Brian Paul<brianp at vmware.com>  wrote:
> >>>> I'd like to have a separate test to check the case of one VBO containing
> >>>> both vertex data and index data.  Would you be interested in writing such a
> >>>> test?
> >>>
> >>> Sure. Something like tests/spec/arb_vertex_buffer_object/combined-vbo.c?
> >>
> >> Hmm, it looks like a combined VBO is used in:
> >> tests/spec/arb_vertex_buffer_object/mixed-immediate-and-vbo.c
> >>
> >> Yet llvmpipe passes arb_vertex_buffer_object-mixed-immediate-and-vbo.
> >
> > I can't get llvmpipe to fail in
> > arb_vertex_buffer_object-mixed-immediate-and-vbo even after tweaking
> > the code. So, perhaps the restart is important here.
> 
> Sounds like it.
> 
> 
> > I'd like to leave the combined VBO for index/vertex data in the
> > primitive-restart test. Do you agree?
> 
> I'd rather have separate VBOs to keep the test focused on one thing 
> (primitive restart).  I really don't have any time now to 
> investigate/fix the single-vbo + restart bug (it might happen with all 
> gallium drivers, btw) so the test would just keep failing for the 
> foreseeable future.  I'd rather not leave it in that state.

Doesn't that mean there should be both tests?

  OG.