[Piglit] [Review Request 1/2] Added triangle rasterisation test.

James Benton jbenton at vmware.com
Mon May 14 08:50:00 PDT 2012

On 14/05/12 16:05, Brian Paul wrote:
> On 05/14/2012 08:59 AM, Brian Paul wrote:
>> On 05/14/2012 08:49 AM, jbenton at vmware.com wrote:
>>> From: James Benton<jbenton at vmware.com>
>>> Ensures correct rasterisation by comparing a randomly drawn triangle
>>> against a software rasteriser.
>>> The software rasteriser complies with the GL spec and has been
>>> verified against nvidia drivers.
>>> V2: Added argument for using maximum texture size
>>> ---
>>> tests/general/CMakeLists.gl.txt | 1 +
>>> tests/general/triangle-rasterisation.cpp | 556
>>> ++++++++++++++++++++++++++++++
>> One minor nit: in the OpenGL spec, it's spelled "rasterization". I
>> have no objection to the "s" spelling other than someone who wants to
>> run piglit tests related to GL rasterization would probably expect to
>> see the spec's spelling.
>> The test looks great otherwise. Do you have piglit commit ability?
>> Reviewed-by: Brian Paul <brianp at vmware.com>
> Oh, you should also add the new test to piglit/tests/all.tests
> -Brian

I did the changes you suggested, including stencil buffer instead of 
logic ops.

I do not have piglit commit ability, however Jose will commit the 
changes for me.

Thanks for the review,
- James

More information about the Piglit mailing list