[Piglit] [PATCH 07/14] cmake: If USE_WAFFLE, disable tests that use quirky GLUT functions

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/22/2012 07:59 AM, Pauli Nieminen wrote:
> On Mon, May 21, 2012 at 11:15:15PM -0700, Chad Versace wrote:
>> If USE_WAFFLE is enabled, do not build the tests below.  The tests use
>> quirky use GLUT functions that will not be implemented in Waffle.
>>     fbo-depth-sample-compare: Uses glutSolidSphere.
>>     windowoverlap: Uses glutCreateSubWindow.
> 
> I have a feeling that creating subwindows in tests might be good idea.
> For example testing race conditions between window state changes
> (resize, composite redirection etc) and rendering operations is a lot
> simpler if test can force the race to happen every time with subwindow.
> 
> Because wayland fixes most of those race conditions we might not any
> more care about X11 races enough to write unit tests.

I agree that it's a good idea to have a subwindows test, but I'm undecided
if Waffle should expose API to create subwindows. We need to investigate how
subwindows work on platforms other than X11, and add API only if it there is
really a platform-independent way of doing it. I don't want Waffle to accumulate
features that only make sense on one platform.

I think the best way to fix this test is to remove the glutCreateSubWindow abstraction
and just call directly to xcb.
 
>>     texwrap: Uses glutBitmapCharacter.
>>     texture-pakced-formats: Uses glutBitmapCharacter.
>>
>> Eventually, these tests need to be repaired so that they no longer require
>> the quirky GLUT functions.  However, the Waffle integration shouldn't be
>> blocked by this small set of tests. Work on reparing these tests can
>> proceed in tandem with the Waffle integration.
>>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>> ---
>>  tests/fbo/CMakeLists.gl.txt       |    6 +++++-
>>  tests/general/CMakeLists.gl.txt   |    6 +++++-
>>  tests/texturing/CMakeLists.gl.txt |   10 +++++++---
>>  3 files changed, 17 insertions(+), 5 deletions(-)


>> +if(NOT USE_WAFFLE)
>> +	# This test uses glutSolidSphere.
>> +	piglit_add_executable (fbo-depth-sample-compare fbo-depth-sample-compare.c)
>> +    endif(NOT USE_WAFFLE)
>> +
> 
> Indent for endif.

Thanks. Will fix in final patch.
 
- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPvAsFAAoJEAIvNt057x8iNeoP/AmmdEG1gOVX8z6vzH3x/Eiq
DHhF+4gUWFyJDcoZSuZnmQVHcZJa0WwLFxxfHaKx1tL9CVICyzfR8CrUa1oHq+Mz
DBd3SrvlE7GRmdeHxFVJegTSIIm11iv/PMuwC8aTdh8w3SVzw+7/yBSoMS4QWrwn
mkrHAa31rkfbThmtkqmoghRlM2U+b7ZoOdbYVBbTFFBQ/eFpso3lnLaTaKQWqATE
VY9CotgiqvRm4i6wA5bowXo7rbbUEkJkaTpUB3chdxHRR0b/XGbhwgYn8CFB0LXB
9VHo6QNVG5ON3bsSOFzdXAi5rdQIGdbb0tpuIKP6blFdzrgrnyxw+44HwDnSo6lB
uQXjXA56v6D8Am01fRSWXyIlxDKbOuLQYyt8LaQwxULSqIaToLLZ8CejDSC/PD6v
lA5ckoJiZhRysx3g3tx0hJxjlp6UA2PK45MCGxZPMdnlJDEVjVI5ZO26yaa8vPuZ
tZ/evqpyg806H2g9xgVW358qOGwAoAhUVBkEiXZ1IuArw+YZTjEyRhkfJvN7H016
WdSjU19LdrAtKNCongAPbF4giRn66zR65U7dzVnYICipTqCOdlvIC+WjQdA8Bslp
yB4PO8edSh7h2DLg51iWjguKQCspIXjgPEs3S2NPp8FiO7n0MfPj7Xo873tT8Wgi
EnI8CDJB2C2E1VPeQ4+v
=O7wb
-----END PGP SIGNATURE-----