[Piglit] [PATCH 06/29] util: Check that glx is supported in the selected platform

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/21/2012 11:08 AM, Pauli Nieminen wrote:
> Check in runtime if current platform is glx before trying to check glX
> versions or extensions.
> 
> Signed-off-by: Pauli Nieminen <pauli.nieminen at linux.intel.com>
> ---
>  tests/util/piglit-glx-util.c |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)

Is the idea for this patch to protect against accidental misuse
of these functions when running tests under X11/EGL? That's the
use scenario I can think of. If that is the use case for this
patch, do any future patches rely on this behavior?

I thought that these functions were only used by tests located in the
tests/glx directory, though I could be mistaken. If the Waffle
platform is not GLX, then the Piglit framework should ensure
that tests in the glx directory are never ran. I don't believe
that it should be test's responsiblity to skip in this case;
the process should have never been started in the first place.

CC'ing Ken because he has also been thinking about related issues.

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPvBFCAAoJEAIvNt057x8iT2MQAKgMXHQQhgXq/eID+oxJU/Iq
0qp2WDFpb+zk3wu4aLFpMjQTyL4N03h+FFQI+pElxCBDrSZnLi67ya7Zgbgkf55l
UJnfPRUqMPbE+SbVKv3LMn3YqZeaWAaoVBzjXie20oqn2kEQATax8jtrz8dEWbA7
AFfsteFvMgSvRos6ASgl42kgEO+ARsRSDcSecb9i2R88Xh6q9iDthJHuCdY+2J0I
FMaj/dIGcPh09hnBtrxH+Mt3D7hhx57jUf4nUbazaJk/moe2OSBdhs0Mx+rEfSvr
mVMXg3+TFXG1Ga2xbkXfk6ivJCTQOWeSz8t9wqrwlmURc7ENd9+lYc+msAjGQExM
zrz5RPk4iCO4mwRNrvdYns+F/zCyW61x5nXkPXLFxtfmAGR8/wjBKyDDDz6DZPGq
1WwuycMP7xA9EBCrtUHx7lUV4MXAZvKUK7J9F1WRspf7KCp5zmuTcDHfmwG5mFNj
NMITHuP28E08Ych2acwzrIeIDDrqQn4sTEClp7NAg9LrCKQkznia7vt8vIZbz1Wq
ql0ZMfpwj1e34/cgNfmlpg1PnvbmZMTFp9nHHk4XuipvzNoDuezVzOqHsfS4Scb8
B4tIvl9QQizJVOohrz7Dei7TDyLtq1r+/5ATQYIPSDko6IvFUZl88BhU7KpVpknX
1ebFQE9qIlQZEFNHXnt7
=50pR
-----END PGP SIGNATURE-----