[Piglit] [PATCH 08/18] util: Disable piglit_glx_window_set_no_input when using Waffle

Chad Versace chad.versace at linux.intel.com
Wed May 23 13:02:16 PDT 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/23/2012 08:46 AM, Pauli Nieminen wrote:
> On Tue, May 22, 2012 at 06:01:48PM -0700, Chad Versace wrote:
>> From: Chad Versace <chad at chad.versace.us>
>>
>> Use #ifdef to disable the function because, when using Waffle and Mesa,
>> XSetWMHints() causes the next emission of DRI2SwapBuffers to fail with
>> BadWindow(X_ChangeProperty). Comment this with FIXME.
>>
> 
> I suppose this is the best temporary solution. But in long term waffle
> could provide API to query the X11 window id to allow library users to
> extend the functionality in a special case that waffle doesn't support.

I digged through Google and GLX lore, and discovered how to fix it.
I just applied the fix to Waffle. If you're interested, here's
the commit:

http://cgit.freedesktop.org/~chadversary/waffle/commit/?id=893ba48bf7c46cc0bbddb3eb0ac98242379f7e25

Since it's fixed in Waffle, I will drop this patch from the series before merging.

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPvUJHAAoJEAIvNt057x8io3QP/0ZmlA4Zf8nMOfxR7J8mnCfv
zUcsu2E3CtDkokZdNG4x5UDgpnBeW8uSSmFILAmpq1woiJRQUa/iPxW+bwo9pK5H
1vn5SLKqOmJA4SC1nVsgrCuF6cb+fgNnbIio0WEiNkSBhK4A1JSidktqKRtCx98k
OHTvyYOUuaA5RAsz5OEhO9yZZ8FwcYWdVM75wE3Q7S5CZC0a8kV1eWaCKlmiToJQ
yWdLc4TqWRUHOzTJQdMGxb5uGuZiD5NpvcpMXVPkawJd/WVqi1pdobvCBH92AiOZ
8e0lY1pCx0XZrsTEo7EY9dQ8TO2QsEBQXJRYZZ++dk5+YUtox5JhhmjLOWdOmH1s
3Y6EP8+9rcT9XUtzHOWFl8lkIRLzEhbuLwVWn2MSFF7Hk7rlDdRwwxSIAUijtJTJ
b7vXT18YGCuVgVF7UuyNZ1bhVWQ4M/g/XfSRlborY5cky8/+xodOYiId8AAaDDMb
GfEpTeLPkwfTxDMN665VJv8WDaOloXXgDTiHAv03ottQghfTDMLwy+9Ma8/6G7Lb
UPXA6iI+uuE3LHQ65Izds8g1+Ehj2Hw6268ruUF0oiLFdNbTIfh3PSqqEx02OtDY
g3iYw0HW6MB+HEd4Qt7yA1IYku0+o3EyEKONkg2TYGgzoh/BVEh/QAm5aTy+ODxU
cJCJ7bn9bG0qTXvOrjWE
=G2r9
-----END PGP SIGNATURE-----


More information about the Piglit mailing list