[Piglit] [PATCH 08/18] util: Disable piglit_glx_window_set_no_input when using Waffle

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/23/2012 01:10 PM, Pauli Nieminen wrote:
> On Wed, May 23, 2012 at 01:02:16PM -0700, Chad Versace wrote:
>> On 05/23/2012 08:46 AM, Pauli Nieminen wrote:
>>> On Tue, May 22, 2012 at 06:01:48PM -0700, Chad Versace wrote:
>>>> From: Chad Versace <chad at chad.versace.us>
>>>>
>>>> Use #ifdef to disable the function because, when using Waffle and Mesa,
>>>> XSetWMHints() causes the next emission of DRI2SwapBuffers to fail with
>>>> BadWindow(X_ChangeProperty). Comment this with FIXME.
>>>>
>>>
>>> I suppose this is the best temporary solution. But in long term waffle
>>> could provide API to query the X11 window id to allow library users to
>>> extend the functionality in a special case that waffle doesn't support.
>>
>> I digged through Google and GLX lore, and discovered how to fix it.
>> I just applied the fix to Waffle. If you're interested, here's
>> the commit:
>>
>> http://cgit.freedesktop.org/~chadversary/waffle/commit/?id=893ba48bf7c46cc0bbddb3eb0ac98242379f7e25
>>
>> Since it's fixed in Waffle, I will drop this patch from the series before merging.
>>
>>
>> ----
>> Chad Versace
>> chad.versace at linux.intel.com
>>
> 
> But you lose FBConfig for the window. As I saied before I don't
> understand GLX details what you lose with that. It might be as simple
> as losing ability to use more generic GLX context with multiple
> windows with different auxlary buffer configurations.
> 
> Pauli

I don't understand either. It looks like we have 3 options
to choose from until we understand the root cause. Each have
advantages and disadvantages.

   1. Disable piglit_glx_window_set_no_input() when using Waffle.
      Waffle continues to use glXCreateWindow().

      - Suffer from Piglit runs that steal input.
      + Avoid potential, unknown problems with FBConfigs and contexts.
      - Expect to suffer from more XID mismatch problems in the future.

   2. Converse of 1.

      + Piglit runs go smoothly.
      - Possibly suffer from problems with FBConfigs and contexts.
      + Avoid future problems caused by XID mismatches.

   3. Halt Waffle/Piglit integration until we solve it.

      - Nobody wants this.

Until we discover the root cause and have a good solution, 2 looks
more attractive than 1.

Chad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPvUg5AAoJEAIvNt057x8ipCEQALLD0YEICLd9OjM0QolQ92Qj
9q07a/VGVNaKtH5+gluznJLgiL0yBbT/a1mtiDy2dBb3UVo9dGbwcAq7Wt2Vjwdq
kvhMySaksek0tSN1D6rTy1qGRyRMTJ5vo+w5QpBuOULDbQ1S/RAqil9WbkJ9kpRd
2kaPLovuJbYO8p4JzwpELRjNMYG2SGYxzfqATX8RIQgyjDrScrnvs1LR80xx2pCf
VSPXjkPsBWQf5POrAb7ZHX0xgZsV2rrNAvvKOepMfe9A/o1j6Epq0L7sjJF3lDO3
bHvNwZZpdDzPwAK7u7liXVBaQhIKm4cry1mkq52E1Amv574QFw1TTdyMF+vuJEQz
w7fBPvP0r2fWnUC6kkT8CByoa+DdkaY+CCPmB0m6Fq1Zx9sE50wNk/KzER/4bmsW
Rw4Us3syuCMPqApFQNllkS1DJgydET2e1TtkFQGHt8oV48upNbDg2QapvW8yNLIc
8xr4s561kwRnsv/rGs84rUJ5IN/grNhp0WgVjmgKD8SE4/Ikq7Rz3vWkCYKVo4r1
W4+z48lwzTga7Y0S//hM0jGWPgqhAu2Dbhr+ONWIPv0Gf8NYjWo/ZkWM6zr6N3v/
fX5eFuWoSvd/K9/DF10pvniMbxVv2oVemwq1oQydhAVLdLNdaj9OEH3I69RbGnMG
JMRCo34hFTm+8Wa5SY28
=RtKe
-----END PGP SIGNATURE-----