[Piglit] [PATCH 0/3] primitive-restart updates (add probe point, cleanup, add VBO)

Jordan Justen jljusten at gmail.com
Thu May 24 13:08:14 PDT 2012

On Thu, May 24, 2012 at 10:14 AM, Brian Paul <brianp at vmware.com> wrote:
> On 05/23/2012 04:48 PM, Jordan Justen wrote:
>> Brian,
>> You had some concerns about my previous primitive-restart + VBO
>> changes, since they caused llvmpipe to fail the primitive-restart
>> test.
>> You were also concerned that I was only testing the case where there
>> was a single combined VBO for vertex + index data, and leaving other
>> combinations untested.
>> Does this version address your concerns?
>> BTW, the 3 patches are also viewable here:
>> http://cgit.freedesktop.org/~jljusten/piglit/log/?h=primitive-restart-vbo
> OK, I finally took a look at the llvmpipe failure and I found the problem.
>  I'll post a patch for that soon.


> The primitive-restart test looks OK to me.

Thanks. Can I consider this "Reviewed-by" you?

>  I think Eric had some concerns though.

True. I think I had addressed all of Eric's concerns in this version.


More information about the Piglit mailing list