[Piglit] [PATCH v4 0/4] add VBO testing to primitive-restart and instanced_arrays

Jordan Justen jljusten at gmail.com
Tue May 29 10:53:38 PDT 2012


On Tue, May 29, 2012 at 7:50 AM, Brian Paul <brian.e.paul at gmail.com> wrote:
> On Sun, May 27, 2012 at 10:37 PM, Jordan Justen
> <jordan.l.justen at intel.com> wrote:
>> Note: This version adds VBO testing to instanced_arrays, but patches 1-3
>> are nearly the same as in v3. (There was a slight modification to all.tests.)
>>
>> v4:
>>  * instanced_arrays: add VBO testing
>>
>> v3:
>>  * primitive-restart: restructure VBO testing into 5 separate tests
>>
>> v2:
>>  * primitive-restart: add probe of point 0,0
>>
>> v1:
>>  * primitive-restart: add VBO testing
>>
>> Jordan Justen (4):
>>  primitive-restart: probe pixel 0, 0 to make sure it was not drawn
>>  primitive-restart: cleanup index generation code
>>  primitive-restart: add VBO testing
>>  arb_instanced_arrays: test instanced_arrays with VBOs
>>
>>  tests/all.tests                                    |   13 +-
>>  tests/general/primitive-restart.c                  |  352 ++++++++++++++------
>>  tests/spec/arb_instanced_arrays/instanced_arrays.c |   47 ++-
>>  3 files changed, 305 insertions(+), 107 deletions(-)
>
> I just had the one comment on the last patch.
>
> Reviewed-by: Brian Paul <brianp at vmware.com>

Thanks, and I'll make the changes you suggested on 3/4 & 4/4.

-Jordan


More information about the Piglit mailing list