[Piglit] [PATCH 5/6] cmake: Remove the REQUIRED flag for PNG

Brian Paul brianp at vmware.com
Mon Nov 5 11:21:28 PST 2012


I don't see any need for libpng either.

-Brian

On 11/05/2012 12:17 PM, Chad Versace wrote:
> Brian and Jose,
>
> Is libpng needed for the Windows build? It is unused on Linux.
>
>
> On 10/24/2012 06:11 AM, groleo at gmail.com wrote:
>> From: Adrian Marius Negreanu<adrian.m.negreanu at intel.com>
>>
>> I haven't found any references to png, except the README file,
>> so I guess it's ok to remove the REQUIRED flag.
>
> I can't find any reference to PNG either. I've confirmed that it's safe to
> completely remove find_package(PNG) on Linux.
>
> Dependant on Brian and Jose's reply, please go ahead and completely
> remove find_package(PNG) and update the README too.
>
>> Signed-off-by: Adrian Marius Negreanu<adrian.m.negreanu at intel.com>
>> ---
>> :100644 100644 719cda1... b48fb5f... M	CMakeLists.txt
>>   CMakeLists.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/CMakeLists.txt b/CMakeLists.txt
>> index 719cda1..b48fb5f 100644
>> --- a/CMakeLists.txt
>> +++ b/CMakeLists.txt
>> @@ -12,7 +12,7 @@ project (piglit)
>>
>>   find_package(TIFF)
>>   find_package(GLUT REQUIRED)
>> -find_package(PNG REQUIRED)
>> +find_package(PNG)
>>   find_package(X11)
>



More information about the Piglit mailing list