[Piglit] [PATCH] egl: Test more invalid GLES2 context versions

Matt Turner mattst88 at gmail.com
Mon Nov 5 16:01:03 PST 2012


On Mon, Nov 5, 2012 at 2:53 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> In test egl-create-context-invalid-gl-version, try to create OpenGL ES2
> contexts with additional invalid versions: 3.2, 3.9, 4.7.
>
> Fails with mesa-84b437 on Intel Sandybridge.
>
> CC: Matt Turner <mattst88 at gmail.com>
> ---
>  tests/egl/spec/egl_khr_create_context/invalid-gl-version.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> index ee33fb9..d83c40b 100644
> --- a/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> +++ b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> @@ -82,6 +82,9 @@ int main(int argc, char **argv)
>                 pass = pass && try_version(0, 0);
>                 pass = pass && try_version(0, -1);
>                 pass = pass && try_version(1, 2);
> +               pass = pass && try_version(3, 2);
> +               pass = pass && try_version(3, 9);
> +               pass = pass && try_version(4, 7);
>
>                 EGL_KHR_create_context_teardown();
>         }
> --
> 1.7.11.7

That looks like it's adding the checks to the if
(EGL_KHR_create_context_setup(EGL_OPENGL_ES_BIT)) block. I suppose we
could check that, but it doesn't look like that's what you meant from
the commit message. Maybe we should have checks to make sure that
asking for version 2.0 of an ES1 context is an error. Doesn't seem
terribly important though.

Since this test is testing invalid versions, what happens when there
actually is a GLES 3.2? :)


More information about the Piglit mailing list