[Piglit] [PATCH 2/2] egl: Add more cases to egl-create-context-invalid-gl-version

[Ian Romanick]

On 11/08/2012 11:00 AM, Chad Versace wrote:
> Fails on mesa-a196f43 with Intel Sandybridge with:
>    Created OpenGL ES1 context with invalid version 3.9
>
> CC: Ian Romanick <idr at freedesktop.org>
> CC: Matt Turner <mattst88 at gmail.com>
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> ---
>   tests/egl/spec/egl_khr_create_context/invalid-gl-version.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> index 9bbce5c..c1c2def 100644
> --- a/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> +++ b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
> @@ -85,6 +85,8 @@ int main(int argc, char **argv)
>   		pass = pass && try_version(0, 0);
>   		pass = pass && try_version(0, -1);
>   		pass = pass && try_version(1, 2);
> +		pass = pass && try_version(2, 9);
> +		pass = pass && try_version(3, 9);
>
>   		EGL_KHR_create_context_teardown();
>   	}
> @@ -93,6 +95,8 @@ int main(int argc, char **argv)
>   		ran_test = true;
>   		pass = pass && try_version(2, -1);
>   		pass = pass && try_version(2, 1);
> +		pass = pass && try_version(3, 9);
> +		pass = pass && try_version(4, 9);

The could still be a version 3.9 or 4.9 someday.  I understand that 
there is still some debate about the use of EGL_OPENGL_ES2_BIT (vs. 
EGL_OPENGL_ES3_BIT_KHR) to create an ES3 context.  Depending on how that 
gets resolved, we may want to check that 3.0 is invalid.

I also suspect that there will be a follow-on patch that tries various 
versions with EGL_OPENGL_ES3_BIT_KHR...  I wonder what should happen 
when the application sets EGL_OPENGL_ES3_BIT_KHR and requests version 2.0...

>
>   		EGL_KHR_create_context_teardown();
>   	}
> @@ -112,6 +116,7 @@ int main(int argc, char **argv)
>   		 * have to include functionality not in 4.0, and that would be weird.
>   		 */
>   		pass = pass && try_version(3, 4);
> +		pass = pass && try_version(4, 9);

There could still be a version 4.9 someday.

>   		EGL_KHR_create_context_teardown();
>   	}
>