[Piglit] [PATCH] egl: Add test egl-create-context-verify-gl-flavor

[Chad Versace]

On 11/08/2012 04:59 PM, Ian Romanick wrote:
> On 11/08/2012 01:20 PM, Ian Romanick wrote:
>> On 11/08/2012 10:19 AM, Chad Versace wrote:

>>> +int
>>> +main(int argc, char **argv)
>>> +{
>>> +        enum piglit_result result = PIGLIT_SKIP;
>>> +
>>> +        /* We call glGetIntegerv with a GL context, a GLES1 context,
>>> +         * and a GLES2 context current. So we shouldn't use the
>>> statically
>>> +         * available symbol provided by libGL. Ditto the other functions
>>> +         * below.
>>> +         */
>>> +        piglit_glGetString = (void*) eglGetProcAddress("glGetString");
>>> +        piglit_glGetIntegerv = (void*)
>>> eglGetProcAddress("glGetIntegerv");
>>
>> Eh... what?
> 
> After our discussion on IRC, I believe that you should remove the GetProcAddress
> business, and just call the functions directly.  I can't conceive of an
> implementation where the GetProcAddress method would work while direct calls
> fail.  If such an implementation did exist, any apps that try to use more than
> one API will be in a world of hurt.

I see your point. See the below-the-commit-message comments in v2 of this patch.