[Piglit] [PATCH 5/5] textureSize: Add support for running with core GL.

Chad Versace chad.versace at linux.intel.com
Tue Nov 13 12:47:23 PST 2012


On 11/01/2012 11:36 AM, Eric Anholt wrote:
> This lets the textureSize tests for TBOs run on i965.
> ---
>  tests/spec/arb_texture_buffer_object/formats.c |    1 +
>  tests/texturing/shaders/textureSize.c          |   18 ++++++++++++++++--
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/spec/arb_texture_buffer_object/formats.c b/tests/spec/arb_texture_buffer_object/formats.c
> index d1ff57d..05a6e2c 100644
> --- a/tests/spec/arb_texture_buffer_object/formats.c
> +++ b/tests/spec/arb_texture_buffer_object/formats.c
> @@ -538,6 +538,7 @@ piglit_display(void)
>  	glGenBuffers(1, &vbo);
>  	glBindBuffer(GL_ARRAY_BUFFER_ARB, vbo);
>  	if (piglit_get_gl_version() >= 31) {
> +		GLuint vao;

I think this hunk should be squashed into patch 3.

>  		glGenVertexArrays(1, &vao);
>  		glBindVertexArray(vao);
>  	}


Other than that,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the Piglit mailing list