[Piglit] [PATCH V2] Add test to verify GL errors in glGenerateMipmap

Brian Paul brianp at vmware.com
Tue Nov 13 16:27:57 PST 2012


On 11/13/2012 05:15 PM, Anuj Phogat wrote:
> It does error checking for glGenerateMipmap() with integer and
> packed depth-stencil texture internal formats.
>
> V2: Don't test formats which generate no error. They are covered
> in other piglit tests.
>
> Signed-off-by: Anuj Phogat<anuj.phogat at gmail.com>
> ---
>   tests/all.tests                          |    1 +
>   tests/spec/gl-3.0/api/CMakeLists.gl.txt  |    1 +
>   tests/spec/gl-3.0/api/genmipmap-errors.c |  154 ++++++++++++++++++++++++++++++
>   3 files changed, 156 insertions(+), 0 deletions(-)
>   create mode 100644 tests/spec/gl-3.0/api/genmipmap-errors.c

Looks good!

I guess one more nitpick would be to add a glDeleteTextures() call, 
but it's not a big deal for this kind of test.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list