[Piglit] [PATCH 3/5] GL_ARB_texture_buffer_object/formats: Add real support for testing GL core.
eric at anholt.net
Wed Nov 14 11:32:52 PST 2012
Chad Versace <chad.versace at linux.intel.com> writes:
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> I have a few open-ended comments on the approach you used here.
> One of the original goals of switching Piglit to Waffle and adding
> a config block to the top of each test was to allow exactly what you're
> accomplishing here: choosing the context flavor with command line arguments.
> It looks like your testing needs outpaced Piglit's implementation.
> I've wanted to add standard command line arguments, similar to -fbo and -auto,
> and modify the config block format to provide a standard way for every test to
> do this. It's still on the drawing board, though. If you have any opinions
> on how you want the final result to look to behave, I'd like to hear them.
I think this test file is a bit special: It actually wants to test
different formats based on which context type. So if one were trying to
run a test of GL functionality but didn't care about looking for context
differences (for speed, similar to how we don't test all visuals), you'd
still want to run the ARB and core variants of this test, unlike say
glsl 1.30 tests where you're probably getting fine coverage on just one
type of context.
Maybe once piglit grows more context selection support (with a notion of
tests that are fine on any context they support vs ones that want to
iterate contexts) we'll want to revisit this, but it seemed reasonable
for the moment.
One thing I'd be interested in is a flag to force a profile regardless
of what the test announces. This would be useful to quickly poke a test
and decide whether the porting effort to allow core-only looks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Piglit