[Piglit] [PATCH 03/14] cmake: Add an Android platform and toolchain

[Chad Versace]

On 11/16/2012 04:46 AM, groleo at gmail.com wrote:
> From: Adrian Marius Negreanu <adrian.m.negreanu at intel.com>
> 
> Signed-off-by: Adrian Marius Negreanu <adrian.m.negreanu at intel.com>
> ---
>  cmake/Modules/Compiler/Android.cmake | 100 +++++++++++++++++++++++++++++++++++
>  cmake/Modules/Platform/Android.cmake |  49 +++++++++++++++++
>  2 files changed, 149 insertions(+)
>  create mode 100644 cmake/Modules/Compiler/Android.cmake
>  create mode 100644 cmake/Modules/Platform/Android.cmake
> 
> diff --git a/cmake/Modules/Compiler/Android.cmake b/cmake/Modules/Compiler/Android.cmake
> new file mode 100644
> index 0000000..a4b03c4
> --- /dev/null
> +++ b/cmake/Modules/Compiler/Android.cmake


> +# Set Android toolchain specifics
> +
> +SET(CMAKE_SYSTEM_NAME Android)
> +SET(CMAKE_SYSTEM_VERSION 1)
> +SET(UNIX True)
> +SET(ANDROID True)
> +
> +# check build/envsetup.sh was sourced
> +IF(NOT DEFINED ENV{ANDROID_BUILD_TOP})
> +    message(FATAL_ERROR
> +    "
> +    build/envsetup.sh is not sourced.

The above line is misleading. Sourcing envsetup.sh does not define
ANDROID_BUILD_TOP.

I think that line should be dropped. The remaining message below
is sufficient to guide the user, and it's correct.


> +     Go to your Android top directory and choose your platform:
> +     . build/envsetup.sh
> +     lunch
> +    "
> +    )
> +ENDIF()

With the small fix above, this patch is
Acked-by: Chad Versace <chad.versace at linux.intel.com>