[Piglit] [PATCH 1/3] glslparsertest: Use integers for GL and GLSL versions

Chad Versace chad.versace at linux.intel.com
Tue Nov 20 12:28:42 PST 2012


On 11/16/2012 04:08 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> I haven't observed any failures with this yet.  Since we just did the
> same thing with shader_runner, it seems like a good idea.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/glslparsertest/glslparsertest.c | 54 +++++++++++++++++++++--------------
>  1 file changed, 33 insertions(+), 21 deletions(-)



> @@ -83,7 +84,7 @@ static char *filename;
>  static int expected_pass;
>  static int gl_version_times_10 = 0;
>  static int check_link = 0;
> -static float requested_version = 1.10;
> +static unsigned requested_version = 11;
                                       ^^^ 110

>  
>  static GLint
>  get_shader_compile_status(GLuint shader)
> @@ -221,7 +222,7 @@ test(void)
>  
>  		shader_prog = piglit_CreateProgram();
>  		piglit_AttachShader(shader_prog, prog);
> -		if (requested_version == 1.00)
> +		if (requested_version == 10)
                                         ^^^ 100

Other than those two off-by-10 errors,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the Piglit mailing list