[Piglit] [PATCH 02/13] util/gl: Add config field 'supports_gl_es_version'

Eric Anholt eric at anholt.net
Wed Nov 28 12:29:38 PST 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> This field allows a test to declare support for any GLES version.  It
> replaces fields 'supports_gl_es1' and 'supports_gl_es2'.
>
> The valid range for the field is currently [1.0, 3.0), though it will soon
> get bumped to [1.0,4.0).

These continuous ranges are weird, given that the only two values really
supported (as far as I can tell) are exactly 1.0 or exactly 2.0.

> One advantage of this field is that it introduces symmetry among the
> 'supports_gl' fields. Before this patch, two fields were integers
> (supports_gl_core_version, supports_gl_compat_version) and two were
> booleans (supports_gl_es1, supports_gl_es2). Now they're all integers and
> behave similarly.

I'm in favor of that, for sure!

> This patch also updates, with the subistition below, the tests that used
                                       ^ spelling
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121128/75b7ba75/attachment.pgp>


More information about the Piglit mailing list