[Piglit] [PATCH] gles-3.0: Add minmax test (v2)

[Chad Versace]

On 11/28/2012 02:59 PM, Tom Gall wrote:
> 
> 
> 
> On Wed, Nov 28, 2012 at 4:10 PM, Chad Versace <chad.versace at linux.intel.com
> <mailto:chad.versace at linux.intel.com>> wrote:
> 
>     This is the first GLES3 test.
> 
>     Tested against Mesa, branch gles3, commit 5612c08 "egl/dri2: Add plumbing
>     for EGL_OPENGL_ES3_BIT_KHR", with Intel Sandybridge.  All testcases pass
>     except:
> 
>       token                         min          actual
>       GL_MAX_ELEMENT_INDEX          16777215     16384
>       GL_MAX_TEXTURE_LOD_BIAS              2.0  -9999.0
>       GL_MAX_SERVER_WAIT_TIMEOUT           0       -1
>       GL_MIN_PROGRAM_TEXEL_OFFSET         -8     9999
> 
>     Currently, all.tests contains the GL tests, all_es1.tests contains the
>     GLES1 tests, and all_es2.tests contains the GLES2 tests. This is the first
>     GLES3 test, so I added the file all_es3.tests. We should really clean that
>     up and put all tests in all.tests.
> 
>     v2: Add tests for the following, for Anholt,
>       GL_MIN_VIEWPORT_DIMENSIONS
>       GL_NUM_*_BINARY_FORMATS
>       GL_MAX_SERVER_WAIT_TIMEOUT
> 
>     Signed-off-by: Chad Versace <chad.versace at linux.intel.com
>     <mailto:chad.versace at linux.intel.com>>
>     CC: Eric Anholt <eric at anholt.net <mailto:eric at anholt.net>>
>     ---
>      tests/all_es3.tests                      |  16 ++++
>      tests/spec/CMakeLists.txt                |   1 +
>      tests/spec/gles-3.0/CMakeLists.gles3.txt |   7 ++
>      tests/spec/gles-3.0/CMakeLists.txt       |   1 +
>      tests/spec/gles-3.0/minmax.c             | 122 +++++++++++++++++++++++++++++++
>      5 files changed, 147 insertions(+)
>      create mode 100644 tests/all_es3.tests
>      create mode 100644 tests/spec/gles-3.0/CMakeLists.gles3.txt
>      create mode 100644 tests/spec/gles-3.0/CMakeLists.txt
>      create mode 100644 tests/spec/gles-3.0/minmax.c
> 
> 
> 
> Should this belong in tests/spec/gles-3.0?
> 
> We have tests/gles2 for instance yet no tests/spec/gles-2.0.   
> 
> Perhaps the tests/gles2 directory should find it's way into tests/spec.

Yes, the test belongs in tests/spec/gles-3.0. The convention is that tests
for specific versions of GL go into tests/spec/$gl_flavor. We already do
this for numerous GL and GLSL versions, including tests/spec/glsl-es-3.00.

The directory tests/gles2 should be removed because it contains nothing
useful. In fact, I just CC'd you on a patch that removes it.