[Piglit] [PATCH] fs-texelFetchOffset-2D: don't assume undefined values to be solid black

Eric Anholt eric at anholt.net
Thu Nov 29 14:43:53 PST 2012


sroland at vmware.com writes:

> From: Roland Scheidegger <sroland at vmware.com>
>
> core GL specifies out-of-bound texel fetches return undefined results,
> except in a robust context with ARB_robust_buffer_access_behavior supported
> (which is core in 4.3), in which case texel fetch will return 0 (OpenGL 4.3
> compatibility profile, page 387, subsection 11.1.3.2 Texel Fetches).
> Since the test requires neither robust context nor that extension it cannot
> assume any specific result value. In any case even returning zero is not what
> the test expected, since it wanted [0,0,0,1] instead.
> (With this change softpipe passes the test, as it clamps the coords.)
>
> v2: fix black->undefined, formatting, comments

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121129/95fe17b4/attachment.pgp>


More information about the Piglit mailing list