[Piglit] [PATCH 4/5] all.tests: Move GLES1 tests into all.tests

Eric Anholt eric at anholt.net
Fri Nov 30 15:36:18 PST 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> No one runs the GLES1 tests. That needs to be fixed.
> If you don't build the GLES1 tests, then piglit-run.py will skip them.

> diff --git a/tests/all.tests b/tests/all.tests
> index 7881c20..521eec9 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -2635,6 +2635,9 @@ if platform.system() is not 'Windows':
>  
>  execfile(path.join(testsDir, 'egl', 'tests.py'))
>  execfile(path.join(testsDir, 'egl', 'spec', 'egl_khr_create_context', 'tests.py'))
> +execfile(path.join(testsDir, 'spec', 'oes_compressed_etc1_rgb8_texture', 'tests.py'))
> +execfile(path.join(testsDir, 'spec', 'oes_compressed_paletted_texture', 'tests.py'))
> +execfile(path.join(testsDir, 'spec', 'oes_draw_texture', 'tests.py'))

I'm not a fan.  I think either we should have a canonical name for
manual test lists that are autodetected like we detect shader_runner
tests, or just not split them out.

(I don't feel any particular need to split test lists out, myself)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121130/1e7f9408/attachment.pgp>


More information about the Piglit mailing list