[Piglit] [Mesa-dev] [PATCH] egl-util: Adds probe_front_pixel_rgb function

Matt Turner mattst88 at gmail.com
Tue Oct 2 14:43:45 PDT 2012

On Tue, Oct 2, 2012 at 7:19 AM, Robert Bragg <robert at sixbynine.org> wrote:
> On Thu, Sep 27, 2012 at 6:48 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Thu, Sep 20, 2012 at 8:59 AM, Robert Bragg <robert at sixbynine.org> wrote:
>>> This adds an egl_probe_front_pixel_rgb function that is analogous to
>>> piglit_probe_pixel_rgba except it probes the front buffer instead of
>>> probing the back buffer.
>>> ---
>>>  tests/egl/egl-util.c |   31 +++++++++++++++++++++++++++++++
>>>  tests/egl/egl-util.h |    4 ++++
>>>  2 files changed, 35 insertions(+), 0 deletions(-)
>> I applied these two patches with the intention of committing them, but
>> they cause egl-nok-swap-region to fail:
>> Front Buffer Probe at (15,15)
>>   Expected: 1.000000 0.000000 0.000000 1.000000
>>   Observed: 0.000000 1.000000 0.000000 0.000000
>> PIGLIT: {'result': 'fail' }
>> The test (before and after) doesn't end on its own either. I have to
>> close it in order to get the test result. I don't know if that's by
>> design, but it's not good for automated piglit testing.
> Hmm that's curious, I just rebased the patches on master, as well as
> the corresponding mesa patch and the test works as expected for me. Is
> it failing for you because you haven't got the mesa patch perhaps? (I
> don't have commit access to land that myself) As for the test
> blocking, I haven't seen that happen before so I don't know what could
> be up there, but I guess it's not related to my changes.
> kind regards,
> - Robert

Ah, I didn't have the Mesa patch applied. It's a really good idea to
say in the Mesa patch that it fixes XXX piglit test.

Also, if your patches aren't committed after a week on the list,
please ping someone so that they don't get lost and forgotten.

Anyway, I'll commit these patches and the Mesa patch. Thanks!

More information about the Piglit mailing list