[Piglit] [PATCH 1/6] cl: Add scalar-load-uchar test

[Blaž Tomažič]

On sre, 2012-10-03 at 17:02 +0000, Tom Stellard wrote:
> From: Tom Stellard <thomas.stellard at amd.com>
> 
> ---
>  tests/all_cl.tests                            |  1 +
>  tests/cl/program/execute/scalar-load-uchar.cl | 15 +++++++++++++++
>  2 files changed, 16 insertions(+)
>  create mode 100644 tests/cl/program/execute/scalar-load-uchar.cl
> 
> diff --git a/tests/all_cl.tests b/tests/all_cl.tests
> index 5cb79f5..b4a54e6 100644
> --- a/tests/all_cl.tests
> +++ b/tests/all_cl.tests
> @@ -122,6 +122,7 @@ add_plain_program_tester_test(program_execute, 'Scalar comparison uchar', 'execu
>  add_plain_program_tester_test(program_execute, 'Scalar comparison uint', 'execute/scalar-comparison-uint.cl')
>  add_plain_program_tester_test(program_execute, 'Scalar comparison ulong', 'execute/scalar-comparison-ulong.cl')
>  add_plain_program_tester_test(program_execute, 'Scalar comparison ushort', 'execute/scalar-comparison-ushort.cl')
> +add_plain_program_tester_test(program_execute, 'Scalar load uchar', 'execute/scalar-load-uchar.cl')
>  add_plain_program_tester_test(program_execute, 'Scalar logical op float', 'execute/scalar-logical-float.cl')
>  add_plain_program_tester_test(program_execute, 'Scalar logical op int', 'execute/scalar-logical-int.cl')
>  add_plain_program_tester_test(program_execute, 'Sizeof operator', 'execute/sizeof.cl')
> diff --git a/tests/cl/program/execute/scalar-load-uchar.cl b/tests/cl/program/execute/scalar-load-uchar.cl
> new file mode 100644
> index 0000000..2b6d910
> --- /dev/null
> +++ b/tests/cl/program/execute/scalar-load-uchar.cl
> @@ -0,0 +1,15 @@
> +/*!
> +[config]
> +name: Scalar load uchar
> +clc_version_min: 11
> +kernel_name: uchar_load
> +
> +[test]
> +name: global address space
> +arg_out: 0 buffer uint[1] 5
> +arg_in:  1 buffer uchar[1] 5
> +!*/
> +
> +kernel void uchar_load(global uint *out, global uchar *in) {
> +	out[0] = in[0];
> +}

Aside from the additional line in patch 3/6 (to which I already replied)
it looks great to me,
Reviewed-by: Blaž Tomažič <blaz.tomazic at gmail.com>

Blaž