[Piglit] [PATCH] all.tests: remove glean/teapot

Eric Anholt eric at anholt.net
Wed Oct 10 11:01:13 PDT 2012


Brian Paul <brianp at vmware.com> writes:

> On 10/09/2012 06:26 PM, Marek Olšák wrote:
>> It doesn't test anything.
>> ---
>>   tests/all.tests |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/all.tests b/tests/all.tests
>> index 964c84c..2c99171 100644
>> --- a/tests/all.tests
>> +++ b/tests/all.tests
>> @@ -115,7 +115,6 @@ glean['rgbTriStrip'] = GleanTest('rgbTriStrip', res_dir)
>>   glean['scissor'] = GleanTest('scissor', res_dir)
>>   glean['shaderAPI'] = GleanTest('shaderAPI', res_dir)
>>   glean['stencil2'] = GleanTest('stencil2', res_dir)
>> -glean['teapot'] = GleanTest('teapot', res_dir)
>>   glean['texCombine'] = GleanTest('texCombine', res_dir)
>>   glean['texCube'] = GleanTest('texCube', res_dir)
>>   glean['texEnv'] = GleanTest('texEnv', res_dir)
>
> I believe that teapot was added as a performance test (several glean 
> tests are perf tests).
>
> The focus of piglit has been correctness but I think it would be nice 
> to develop a suite of performance measurement tests too.  But that's a 
> whole other discussion.

If anybody builds a performance suite, I bet the teapot won't be in it.

(Hopefully we can use apitrace for the job some day, though currently
the decompression overhead is too high)

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121010/30797486/attachment.pgp>


More information about the Piglit mailing list