[Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

[Chad Versace]

On 10/10/2012 01:31 PM, Matt Turner wrote:
> On Wed, Oct 10, 2012 at 11:04 AM, Chad Versace
> <chad.versace at linux.intel.com> wrote:
>> On 10/08/2012 04:57 PM, Matt Turner wrote:
>>> ---
>>>  tests/all_egl.tests                                |    1 +
>>>  .../spec/egl_khr_create_context/CMakeLists.gl.txt  |    1 +
>>>  .../spec/egl_khr_create_context/pre-GL3-profile.c  |  115 ++++++++++++++++++++
>>
>> I think "pre-GL32-profile" would be a better name for this test. The name
>> "pre-GL3-profile" is misleading.
> 
> Reasonable. Do we also rename the GLX test?

Yes, I think we should.

> Do you think this adds significantly to the comment in main()?
> 
>          *     "When the current rendering API is EGL_OPENGL_API, the value of
>          *     EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR requests an OpenGL context
>          *     supporting the corresponding profile... If the requested OpenGL
>          *     version is less than 3.2, EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR is
>          *     ignored and the functionality of the context is determined solely
>          *     by the requested version."
>          *
>          * Try to create a context without any profile specified.  If that
>          * works, try to create a context with the core profile specified.
>          * That should also work.
> 
> I don't really think it does. None of the other tests have top level
> comments either. All the tests do have comments explaining what's
> going on though, including the tests I'm adding now.

I see your point. Perhaps I was being too picky about the comment issue.

I withdraw my comment objections to patches 2-4. That makes patch 2 reviewed-by.
But there are still issues with patches 3-4. Patch 3 has the weird line break in
printf. And patch 4 has the bug and misleading name.

-Chad