[Piglit] [PATCH] piglit: fix crashes when using original GLUT

Brian Paul brianp at vmware.com
Mon Oct 15 11:12:22 PDT 2012

On 10/15/2012 12:08 PM, Chad Versace wrote:
> On 10/15/2012 10:30 AM, Brian Paul wrote:
>> The glutInit() function in the original GLUT expects argv[0] to be the
>> program name (as from main()), not a NULL pointer.  A strrchr() call
>> crashes on NULL.
>> For now, set argv[0]="piglit".  Previously, glutInit would get the
>> program path/name and it would appear in the window title.
>> This seems to be a regression since the waffle changes.
>> ---
> Looks good to me.
> Reviewed-by: Chad Versace<chad.versace at linux.intel.com>
> Brian, I'm curious on what OS and version of GLUT you found this problem. On
> Fedora 17 with freeglut-2.8.0 the segfault doesn't happen.

This was on a Fedora 14 system.  The GLUT is mesa-glut.  I'm pretty 
sure the difference is freeglut vs. Kilgard's GLUT.


More information about the Piglit mailing list