[Piglit] [PATCH] util: Fix visual selection when using waffle

Eric Anholt eric at anholt.net
Tue Oct 16 12:57:26 PDT 2012

Chad Versace <chad.versace at linux.intel.com> writes:

> Only request a visual with alpha if the test requests
> When I wrote the waffle backend, I misunderstood the meaning of GLUT_RGBA.
> I interpreted GLUT_RGBA to indicate a request for a visual with all of
> RGBA channels present. Actually, it just indicates a request for a visual
> with RGBA color model, as opposed to GLUT_LUMINANCE and GLUT_INDEX.
> Fixes regression in fs-texelFetchOffest-2D.
> Reported-by: Marek Olšák <maraeo at gmail.com>
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>

We should fix those tests to work correctly in the presence of alpha in
the visual.  The system could have all visuals with alpha, and the test
should deal with it.

That said, I'd like to see some sanity in the PIGLIT_GL_VISUAL now that
we're not glut any more.  The glut interface was awful and a total trap.
I think we should replace RGB | ALPHA with RGBA, and make RGB ask for
RGB and RGBA ask for RGBA.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121016/0dbe8dea/attachment.pgp>

More information about the Piglit mailing list