[Piglit] [PATCH] util: Fix visual selection when using waffle

[Marek Olšák]

There is one test fdo25614-genmipmap which reproduces a bug only
occuring with a framebuffer without alpha. If we enforce RGBA
everywhere, not only would the test be useless, but also we'd end up
with the RGBX framebuffer config mostly untested.

While it's useful to have RGBA framebuffers in most tests, we should
not remove support for RGBX framebuffers entirely.

Marek

On Tue, Oct 16, 2012 at 9:57 PM, Eric Anholt <eric at anholt.net> wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
>
>> Only request a visual with alpha if the test requests
>> PIGLIT_GL_VISUAL_ALPHA.
>>
>> When I wrote the waffle backend, I misunderstood the meaning of GLUT_RGBA.
>> I interpreted GLUT_RGBA to indicate a request for a visual with all of
>> RGBA channels present. Actually, it just indicates a request for a visual
>> with RGBA color model, as opposed to GLUT_LUMINANCE and GLUT_INDEX.
>>
>> Fixes regression in fs-texelFetchOffest-2D.
>>
>> Reported-by: Marek Olšák <maraeo at gmail.com>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>
> We should fix those tests to work correctly in the presence of alpha in
> the visual.  The system could have all visuals with alpha, and the test
> should deal with it.
>
> That said, I'd like to see some sanity in the PIGLIT_GL_VISUAL now that
> we're not glut any more.  The glut interface was awful and a total trap.
> I think we should replace RGB | ALPHA with RGBA, and make RGB ask for
> RGB and RGBA ask for RGBA.
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>