[Piglit] [PATCH 0/8] Add GBM support

Chad Versace chad.versace at linux.intel.com
Fri Oct 19 09:54:00 PDT 2012


This series looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

I wanted to test the series, but the python patches wouldn't apply :(

I still want to discuss with you how to get the gbm tests running under X and
Wayland when we're in the office at the same time.

-Chad

On 10/09/2012 04:42 PM, Jordan Justen wrote:
> Dependencies:
> * Waffle 1.1
> * Chad Versace's "Support tests for GL core contexts" series
> 
> Some results I've seen:
> GLX:                      9092/9294
> GBM (waffle master):      8245/8417
> GBM (w/unpushed changes): 8673/8820 
> 
> Notes:
> * When X is running, waffle-gbm currently must be run as root
> * When outside of X, a normal user can be used, but you should 
>   not run tests concurrently: piglit-run.py -c 0
> 
> Jordan Justen (8):
>   piglit-run.py: add -p|--platform switch to select the piglit platform
>   exectest.py: move test launch code out to get_command_result routine
>   exectest.py: add path to mark a test as always skipped
>   exectest.py: set python PIGLIT_PLATFORM from environment variable
>   gbm: when using gbm, skip running glean tests
>   gbm: when using gbm, skip running glx tests
>   waffle: require waffle >= 1.1
>   piglit framework: add gbm support
> 
>  CMakeLists.txt                                     |    5 +-
>  framework/core.py                                  |    1 +
>  framework/exectest.py                              |   83 ++++++++++++++------
>  piglit-run.py                                      |   10 ++-
>  tests/util/CMakeLists.txt                          |    1 +
>  .../piglit-framework-gl/piglit_gbm_framework.c     |   78 ++++++++++++++++++
>  .../piglit-framework-gl/piglit_gbm_framework.h     |   29 +++++++
>  .../piglit-framework-gl/piglit_wfl_framework.c     |   10 +++
>  .../piglit-framework-gl/piglit_winsys_framework.c  |    6 ++
>  9 files changed, 195 insertions(+), 28 deletions(-)
>  create mode 100644 tests/util/piglit-framework-gl/piglit_gbm_framework.c
>  create mode 100644 tests/util/piglit-framework-gl/piglit_gbm_framework.h
> 



More information about the Piglit mailing list