[Piglit] [PATCH] add a PIGLIT_BUILD_GL_TESTS option

Negreanu Marius groleo at gmail.com
Mon Oct 22 14:02:57 PDT 2012


On Mon, Oct 22, 2012 at 11:52 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> NAK. Reasons below.
>
> As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be a
> cmake option, enabled by default on Linux, and base decisions on the option. I
> generally frown on build systems that make decisions based on autodetected
> dependencies.

Thanks for the review ; I'll work this one a bit more .

-- 
Regards!
http://groleo.wordpress.com


More information about the Piglit mailing list