[Piglit] [PATCH] Add OpenCL support

[Blaž Tomažič]

On tor, 2012-09-04 at 07:14 -0700, Tom Stellard wrote:
> On Thu, Aug 30, 2012 at 02:02:55AM +0200, Blaž Tomažič wrote:
> > I have implemented an OpenCL testing framework for Piglit which I would
> > like to merge upstream. Here is a summary of its functionality:
> > 
> >         The framework implements OpenCL utilities which are used for
> >         quicker and easier writing of tests.
> >         
> >         Test that are written against the framework can be defined to be
> >         run once, per each platform or per each device. Each test can be
> >         limited to a particular group of platforms or devices.
> >         
> >         There are different test types to chose from when writing a
> >         test. Each type exposes configuration variables that are used to
> >         automatically check for different implementation functionality
> >         (OpenCL version, extensions, filter by platform name,...) and
> >         create objects (context creation, program creation and building,
> >         source code loading, buffer creation and buffer data
> >         initialization,...), so there is less coding needed when writing
> >         a test.
> > 
> > A little bigger description about the framework, and how to use it, is
> > located here [1] and also in one of the commits (doc: Add cl tests
> > documentation).
> > 
> > This patch would add this framework to Piglit and about 70 tests that
> > are implemented with it.
> > 
> > The patch is quite large, but the commits that modify already present
> > files are really small (cmake: and README: commits). The other commits
> > only add new files.
> > 
> > Blaž Tomažič
> > 
> > [1] https://raw.github.com/blazt/piglit/opencl-request/tests/cl/README
> >
> 
> Hi Blaž,
> 
> Overall, this looks really good, and I especially like all the
> documentation, just two things:
> 
> I noticed that the license headers you are using reference IBM and VA
> Linux.  You should double check the license and make sure it is what
> you want.  Take a look at: tests/gles2/gles2_shader_runner.c for an
> example of a standard license used in piglit.

Should be fixed now, I used the license from
tests/gles2/gles2_shader_runner.c.

> Some of the cl-util files contain some really long lines, especially
> piglit-framework-cl-program.c:96-99.  You should go through and wrap some
> of the longer lines at 80 characters to make them easier to read.

I went through all the code and wrapped as much of it as possible to 80
lines.

The new fixed branch is now at:
        git://github.com/blazt/piglit.git opencl-request-v2

Blaž Tomažič