[Piglit] [PATCH] glean/texCombine: test fewer combinations

Brian Paul brianp at vmware.com
Wed Sep 12 06:15:07 PDT 2012


On 09/11/2012 08:28 PM, Marek Olšák wrote:
> It takes 10 minutes for llvmpipe to finish this test. With this patch,
> it takes 20 seconds.
>
> Before:
>
> Tested 104 GL_REPLACE combinations
> Tested 7540 GL_ADD combinations
> Tested 7540 GL_ADD_SIGNED_EXT combinations
> Tested 7540 GL_MODULATE combinations
> Tested 5957 GL_INTERPOLATE_EXT combinations
> Tested 7540 GL_DOT3_RGB_EXT combinations
> Tested 7540 GL_DOT3_RGBA_EXT combinations
> Tested 47662 GL_MODULATE_ADD_ATI combinations
> Tested 47662 GL_MODULATE_SIGNED_ADD_ATI combinations
> Tested 47662 GL_MODULATE_SUBTRACT_ATI combinations
> Tested 218 multitexture combinations
> Tested 8 crossbar combinations
>
> After:
>
> Tested 17 GL_REPLACE combinations
> Tested 1237 GL_ADD combinations
> Tested 1237 GL_ADD_SIGNED_EXT combinations
> Tested 1237 GL_MODULATE combinations
> Tested 978 GL_INTERPOLATE_EXT combinations
> Tested 1237 GL_DOT3_RGB_EXT combinations
> Tested 1237 GL_DOT3_RGBA_EXT combinations
> Tested 7825 GL_MODULATE_ADD_ATI combinations
> Tested 7825 GL_MODULATE_SIGNED_ADD_ATI combinations
> Tested 7825 GL_MODULATE_SUBTRACT_ATI combinations
> Tested 35 multitexture combinations
> Tested 8 crossbar combinations
> ---
>   tests/glean/ttexcombine.cpp |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/glean/ttexcombine.cpp b/tests/glean/ttexcombine.cpp
> index 9f0b47e..5c5234d 100644
> --- a/tests/glean/ttexcombine.cpp
> +++ b/tests/glean/ttexcombine.cpp
> @@ -1609,7 +1609,7 @@ TexCombineTest::runOne(BasicResult&  r, Window&  w) {
>
>   	// If quick mode, run fewer tests
>   	if (env->options.quick)
> -		testStride = 11;  // a prime number
> +		testStride = 67;  // a prime number
>   	else
>   		testStride = 1;
>

Reviewed-by: Brian Paul <brianp at vmware.com>

There's probably some other glean tests (blendFunc?) that could be 
made faster too.

-Brian


More information about the Piglit mailing list