[Piglit] [PATCH] Clean up depth-tex-modes-glsl a bit.

Brian Paul brianp at vmware.com
Mon Sep 24 07:05:33 PDT 2012


On 09/23/2012 09:51 PM, Kenneth Graunke wrote:
> 1. It doesn't use sampler2DRect, so don't require ARB_texture_rectangle
> 2. Remove pointless glFinish() before piglit_present_results()
> 3. Use Piglit utility functions for compiling/linking shaders.
> 4. Print the description of what you're seeing in *non*-automatic mode.
>
> Signed-off-by: Kenneth Graunke<kenneth at whitecape.org>
> ---
>   tests/texturing/depth-tex-modes-glsl.c | 29 ++++-------------------------
>   1 file changed, 4 insertions(+), 25 deletions(-)
>
> I was originally considering extending this test to do EXT_texture_swizzle
> rather than writing a new one.  So I started by cleaning it up a bit.
>
> In the end I decided to write a new test anyway (already reviewed on the
> list), but figured the cleanups are worthwhile anyway.
>

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the Piglit mailing list