[Piglit] [PATCH] CL Builtin: Remove an invalid mad24 test

Tom Stellard tom at stellard.net
Mon Apr 1 11:01:12 PDT 2013


On Sun, Mar 31, 2013 at 09:08:24AM -0500, Aaron Watry wrote:
> The CL spec says that the results of this test are undefined.  mad24 and mul24 assume that the
> input values are 24-bit integers, and anything in the upper 8 bits gets treated in an
> implementation-defined manner.
> ---

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

>  generated_tests/generate-cl-int-builtins.py |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/generated_tests/generate-cl-int-builtins.py b/generated_tests/generate-cl-int-builtins.py
> index 2460594..1936454 100755
> --- a/generated_tests/generate-cl-int-builtins.py
> +++ b/generated_tests/generate-cl-int-builtins.py
> @@ -577,10 +577,10 @@ builtins = {
>              'arg_types': [T, T, T, T],
>              'function_type': 'ttt',
>              'values': [
> -                [0,2, 0,520,     1],
> -                [0,1,-1, 32, 2**30],
> -                [0,1,-1, 16,     1],
> -                [0,1,-1,  8,     1]
> +                [0, 2,  0, 520],
> +                [0, 1, -1,  32],
> +                [0, 1, -1,  16],
> +                [0, 1, -1,   8]
>              ]
>          },
>          'mul24':{
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list